ID

Uploaded

Status

Description

Work Items

Action

9135
by pcpdx
Apr 13 2011
4:47 PM

Being evaluated

/Blog4Umbraco/AjaxCommentForm.ascx does not work when Javascript is disabled.

The problem is the post is looking for "author" when the field is "name". This subesquently causes the valid comment check on line 34 of Base.cs to fail as the name property is null.

I propose the ajaxCommentForm be changed to better utilize the .net framework and controls as this current version - while is functional with this patch, leaves a little desire for the UX. For example - if the JS-disabled user enters an invalid message, there is no feedback for why their comment has failed. Furthermore, all of their input is gone.
If the user does have a successful comment - they are not presented any feedback message of success or similar. In past experience, if a user doesn't get feedback they will hit [f5] or refresh several times and then give up. -Little do they know that their comment has actually been posted and by hitting refresh so many times..it's been posted 3/4/5/19 times!
I am updating this code in our local as we need to be able to support these changes. I will submit them when i am done should you choose to use them - i strongly urge an update to the ux in any case.

Thanks for all the hard work you have done on this great package!
Hope i can help

Download

8345
by ulu
Feb 12 2011
4:28 PM

Being evaluated

Fixes a bug: comments are not saved. The problem was that field names do not correspond to what is read by the method in the Base class. Did a bit of refactoring. Also, added a redirect after the form submit (prevents from duplicate submission).

Download

6390
by dseefeld
Jul 22 2010
7:15 AM

Being evaluated

I figured out an even better fix for the path error in /DataTypes/SkinBrowser.cs. It is to replace ~/ with the appname:

protected override void OnLoad(EventArgs e)
{
base.OnLoad(e);
Page.ClientScript.RegisterClientScriptInclude("skinBrowser", ReplaceWithAppPath(GlobalSettings.Path) + "/plugins/blog4umbraco/skinBrowser.js");
umbraco.uicontrols.helper.AddLinkToHeader("skinBrowser", ReplaceWithAppPath(GlobalSettings.Path) + "/plugins/blog4umbraco/skinBrowser.css", this.Page);
}

...

private static string ReplaceWithAppPath(string str)
{
string appPath = HttpContext.Current.Request.ApplicationPath;

//Ensure the app path ends w/ a slash
if (!appPath.EndsWith("/"))
appPath += "/";

return str.Replace("~/", appPath);
}

5121

Download

6373
by dseefeld
Jul 21 2010
12:49 AM

Being evaluated

Patch update - fixed line 24,25 in DataTypes\SkinBrowser.cs and copied \bin\ICSharpCode.SharpZipLib.dll from Umbraco 4.5 build.

5121

Download

6372
by dseefeld
Jul 20 2010
7:14 PM

Being evaluated

I found and fixed two problems with the skin upload function in v4.5. First has deals with an error in js/css file path. Second updates the ICSharpCode.SharpZipLib.dll to .Net 4. A detailed description is in the attached zip.

Download

6333
by dseefeld
Jul 15 2010
10:10 AM

Being evaluated

I fixed some xslt for version 4.5. The resluts look right to me. But I am not sure about this kind of changes i. e. in BlogListPost.xslt line 64: old: <xsl:if test="$currentPage/@nodeTypeAlias = 'DateFolder'"> new: <xsl:if test="$currentPage/self::DateFolder">

Download

5729
by webangelo
Apr 9 2010
8:28 PM

Being evaluated

Possible option for Separate Post Date.

875

Download

5643
by webangelo
Mar 30 2010
6:44 PM

Being evaluated

Add Catch for ArgumentException to allow for Preview

Download

5303
by ovalsquare
Feb 19 2010
6:26 AM

Being evaluated

Removes script injection vulnerability in comment form as described in Work Item 4059. Probably commits a cardinal sin because patch covers other small changes in Umlaut.Umb.Blog.Library.base.cs including an improved email regex (in patch 4804) as I had already implemented various fixes for my own build.

Download

5029
by bigfinger
Jan 22 2010
3:36 PM

Being evaluated

Fixes issue.

3901

Download

View All